Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After expand label makes the table bigger #18840

Open
peterhashair opened this issue Feb 23, 2022 · 1 comment
Open

After expand label makes the table bigger #18840

peterhashair opened this issue Feb 23, 2022 · 1 comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone
Backlog (Help wan...

Comments

@peterhashair
Copy link
Contributor

peterhashair commented Feb 23, 2022 •
edited

This is a follow-up issue, the original is an issue is here, #18699. PR #18728 fix the shortened label but resize the table bigger.

The reason this happened is the expanded table has extra width on the title. When expanded triggered, it will resize the entire table to recalculate the title width.

This is caused by this line here.

matomo/plugins/CoreHome/javascripts/dataTable.js

Line 489 in f870e36

return parseInt(labelWidth / $('tr:nth-child(1) td.label', domElem).length, 10);

Reproduce

To reproduce it use Behaviours->Contents or Events. Click to expand any of the Product X will make the table bigger.

Screenshots

test.site.1.-.Web.Analytics.Reports.-.Matomo.mp4
@peterhashair peterhashair added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Feb 23, 2022
@peterhashair peterhashair added this to the 4.9.0 milestone Feb 23, 2022
@tsteur
Copy link
Member

tsteur commented Feb 23, 2022

@peterhashair could you describe this issue in detail please? Like how to reproduce it, how much it makes the table bigger (ideally screenshots) etc. This will help us asses the impact to know when we need to fix it

@tsteur tsteur modified the milestones: 4.9.0, 4.10.0 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @justinvelluppillai @peterhashair