Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] add report date on overview reports and fix date display #18838

Merged
merged 14 commits into from Mar 7, 2022
Merged

[UI] add report date on overview reports and fix date display #18838

merged 14 commits into from Mar 7, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Feb 23, 2022 •
edited

Description:

Fixes: #18806

add report date on overview reports and fix date display.
When the overview type is DataMap, get the last item ts_archived as the report date.
Screen Shot 2022-02-23 at 3 46 13 PM

Review

Peter and others added 2 commits February 23, 2022 14:22
@peterhashair peterhashair added this to the 4.8.0 milestone Feb 23, 2022
@peterhashair peterhashair added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 23, 2022
sgiehl
sgiehl requested changes Feb 23, 2022
View reviewed changes
plugins/CoreHome/templates/_dataTable.twig Outdated Show resolved Hide resolved
core/DataTable/Map.php Outdated Show resolved Hide resolved
core/Plugin/Visualization.php Outdated Show resolved Hide resolved
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Feb 23, 2022
Peter Zhang and others added 2 commits February 24, 2022 09:59
@sgiehl
Update plugins/CoreHome/templates/_dataTable.twig
c87d175 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
update largest key
4c1eb03 
update largest key
sgiehl
sgiehl requested changes Feb 24, 2022
View reviewed changes
core/DataTable/Map.php Outdated Show resolved Hide resolved
core/DataTable/Map.php Outdated Show resolved Hide resolved
@peterhashair
Copy link
Contributor Author

@sgiehl update a little, but I guess here could be the problem, eg: the first item ts_created not exist. Any suggestions?

 if (!isset($metaData[DataTable::ARCHIVED_DATE_METADATA_NAME])) {
                        break;
 }

sgiehl
sgiehl requested changes Feb 25, 2022
View reviewed changes
core/Plugin/Visualization.php Outdated Show resolved Hide resolved
core/Plugin/Visualization.php Outdated Show resolved Hide resolved
core/Plugin/Visualization.php Outdated Show resolved Hide resolved
Update Visualization.php
c284fe2 
update some condition
@peterhashair peterhashair added the Needs Review PRs that need a code review label Feb 27, 2022
@justinvelluppillai justinvelluppillai modified the milestones: 4.8.0, 4.9.0 Mar 1, 2022
Peter added 2 commits March 2, 2022 10:27
Update Visualization.php
e0864aa 
convert meta data to local var
ini $metadata
1a6b647 
ini $metadata
@sgiehl
Update core/Plugin/Visualization.php
595888c 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl sgiehl merged commit 8188140 into 4.x-dev Mar 7, 2022
@sgiehl sgiehl deleted the m-18806 branch March 7, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

Inline Help - show report generation date on "Overview" reports with Evolution Graphs
3 participants
@peterhashair @sgiehl @justinvelluppillai