New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comparison trends might be displayed incorrect for certain languages #18832
Conversation
05140f1
to
2a66056
Compare
1f2f174
to
2a66056
Compare
ab3458e
to
771b779
Compare
771b779
to
75210be
Compare
@tsteur I have simplified the PR. The additional columns will now only be requested by the sparkline visualization and thus won't occur in any API output. |
e4609dc
to
d71c210
Compare
I've put it for now into 4.9. I had a quick look and it looks OK but I can't do a full review due to time. Be great for someone to do later a full review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
@diosmosis It seems the test I had added to this PR starts failing after #18761 has been merged in. The sparklines lost their color. See https://builds-artifacts.matomo.org/matomo-org/matomo/fixcomparisontrend/54586/Comparison_visits_overview_widget_sv.png I guess the javascript method to initialize the sparklines is called before the colormanager, which is in Vue, has been loaded fully. The sparline requests contain |
@sgiehl that's weird, ColorManager is still in vanilla JS. I'll take a look. |
@sgiehl should be fixed |
Description:
fixes #18802
Review