@sgiehl opened this Pull Request on February 21st 2022 Member

Description:

fixes #18802

Review

@sgiehl commented on February 23rd 2022 Member

@tsteur I have simplified the PR. The additional columns will now only be requested by the sparkline visualization and thus won't occur in any API output.

@tsteur commented on February 23rd 2022 Member

I've put it for now into 4.9. I had a quick look and it looks OK but I can't do a full review due to time. Be great for someone to do later a full review

@github-actions[bot] commented on March 5th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@sgiehl commented on March 7th 2022 Member

@diosmosis It seems the test I had added to this PR starts failing after https://github.com/matomo-org/matomo/pull/18761 has been merged in. The sparklines lost their color. See https://builds-artifacts.matomo.org/matomo-org/matomo/fixcomparisontrend/54586/Comparison_visits_overview_widget_sv.png

I guess the javascript method to initialize the sparklines is called before the colormanager, which is in Vue, has been loaded fully. The sparline requests contain "lineColor":[null,null]
Would you mind having a look and maybe pushing a fix on this branch?

@diosmosis commented on March 7th 2022 Member

@sgiehl that's weird, ColorManager is still in vanilla JS. I'll take a look.

@diosmosis commented on March 7th 2022 Member

@sgiehl should be fixed

This Pull Request was closed on March 8th 2022
Powered by GitHub Issue Mirror