Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible warning #18830

Merged
merged 1 commit into from Feb 21, 2022
Merged

Fix possible warning #18830

merged 1 commit into from Feb 21, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 21, 2022 •
edited

Description:

That was the only occurrence in core I could find, where PageUrl::normalizeUrl might be called with a null value.

fixes #18829

refs #17686

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 21, 2022
@sgiehl sgiehl added this to the 4.8.0 milestone Feb 21, 2022
@justinvelluppillai justinvelluppillai merged commit d21506d into 4.x-dev Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Fix possible dashboard warning
2 participants
@sgiehl @justinvelluppillai