Fix cookies with session lifetime #18820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As a regression from #18179 cookies with session lifetime don't work anymore.
As stated in the Cookie class an expire of
0
should indicate a session cookie:matomo/core/Cookie.php
Lines 81 to 82 in 9c666ab
But that doesn't work anymore as the lifetime will be always converted to a datetime, resulting in
01-Jan-1970 00:00:00 UTC
, causing the cookie to be never set.fixes #18819
Review