Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals: revenue overflow (e.g., reporting $ 3.40282E+38 as overall revenue) #1882

Closed
tgr opened this issue Dec 9, 2010 · 6 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@tgr
Copy link

tgr commented Dec 9, 2010

I tried to measure a donation goal on a PayPal form, and after a few days, Piwik says "$ 3.40282E+38 overall revenue" and breaks when requesting any details (the breakage is due to bug #1847). After deleting the goal and replacing with a new one, it works normally for a short while, then shows 3.40282E+38 revenue again. The donation numbers seem correct, only the revenues are affected.

3.40282E+38 is the maximum value a float can hold, so maybe this is some sort of conversion error? The revenue is logged manually via @piwikTracker.trackGoal@, and the second parameter looks like this: @10000.00@

@robocoder
Copy link
Contributor

Can you query your log_conversion table, and see what's being recorded in the revenue column?

@robocoder
Copy link
Contributor

(In [3427]) refs #1882 - cast non-default return values

@tgr
Copy link
Author

tgr commented Dec 10, 2010

There are a lot of numbers that correspond to real donations, and a few obviously wrong ones. Currently, two days after the last time of deleting old results and starting anew, there are two such records, along with ~100 real ones: 1.5e+07 and 9.99e+11. (It is possible these are pranks, or attacks of some sort; some could just type in some very high number, click Donate and close the Paypal window which comes up next without donating. I cannot imagine who would bother with that, though.)

@robocoder
Copy link
Contributor

Why not append the revenue to the return url, and trackGoal on the confirmation?

@mattab
Copy link
Member

mattab commented Dec 12, 2010

I would advise, like vipsoft, to check for the amount on the client side. This wouldn't prevent users faking the request to piwik.php directly, but I'm not sure how we could avoid these (arbitrary revenue threshold below/above which we ignore the conversions? User defined range of valid revenues?)

@mattab
Copy link
Member

mattab commented Dec 20, 2010

wontfix for now, can reopen if problem occurs again

@tgr tgr added this to the Piwik 1.1 milestone Jul 8, 2014
@tgr tgr added T: Bug labels Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants