Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options request will also be recorded #18812

Closed
5idu opened this issue Feb 17, 2022 · 7 comments · Fixed by #19030
Closed

options request will also be recorded #18812

5idu opened this issue Feb 17, 2022 · 7 comments · Fixed by #19030
Assignees
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone

Comments

@5idu
Copy link

5idu commented Feb 17, 2022

Expected Behavior

options request should not recorded!

Current Behavior

options request will also be recorded

Possible Solution

The server should filter out the options request and not participate in the record.

Steps to Reproduce (for Bugs)

image

image

Context

Your Environment

  • Matomo Version: 4.7.1
  • MySQL version: 10.6.5-MariaDB-1:10.6.5+maria~focal
  • PHP Version: 8.0.15
  • Server Operating System: centos7
  • Additionally installed plugins:
  • Browser: chrome98
  • Operating System: macos 12.1
@5idu 5idu added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Feb 17, 2022
@tsteur tsteur added this to the 5.0.0 milestone Feb 17, 2022
@5idu
Copy link
Author

5idu commented Feb 18, 2022

@tsteur Hi, are you sure this is a bug? and will be fixed in the next version?

@tsteur
Copy link
Member

tsteur commented Feb 18, 2022

@5idu I haven't looked into this yet but put it for now into Matomo 5 to consider changing this there. This release could be 6-12 months away as we don't have specific plans for a Matomo 5 release yet. We probably wouldn't want to change anything there earlier just in case it would cause any kind of regressions where people rely on this working for some reason.

@5idu
Copy link
Author

5idu commented Feb 18, 2022

@tsteur Thanks Reply. looking forward to your verification result.
Now my solution is to intercept the options request on nginx, and then the statistical results are normal.

@tsteur
Copy link
Member

tsteur commented Feb 18, 2022

@5idu do you know what issues these OPTIONS requests in the first place?

@5idu
Copy link
Author

5idu commented Feb 18, 2022

@tsteur since cross-domain, browser client send the options request, this is fine.
However, after the options request is sent to the matomo server, matomo will still process the data passed by the options request, resulting in repeated statistics.

@tsteur tsteur removed this from the 5.0.0 milestone Feb 18, 2022
@tsteur
Copy link
Member

tsteur commented Feb 18, 2022

Thanks for this, that's really helpful. I will move this in the 4.9 milestone so we look into this earlier. If someone in the team could reproduce this that be great.

@tsteur tsteur added this to the 4.9.0 milestone Feb 18, 2022
@tsteur tsteur added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Mar 2, 2022
@peterhashair peterhashair self-assigned this Mar 27, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Mar 29, 2022

Haven't reproduced this locally, but this could be caused by CORS preflight, I guess we could filter those request types, stop them for the double record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants