Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native click event handler not triggered on dashboard manager top control #18808

Merged
merged 1 commit into from Feb 18, 2022

Conversation

diosmosis
Copy link
Member

Description:

To reproduce issue:

  1. Create new dashboard with no widgets.
  2. When the dashboard loads it will show a modal saying to add a widget or set to default layout. Click "Add a widget".
  3. This should expand the dashboard manager, but does not currently.

Cause is due to ExpandOnClick using a native event handler on a link then trying to use jquery.trigger('click') to trigger the handler. jQuery sometimes ignores native event handlers, but not always, and it is complex to make it work in every case.

Also added some environment variables to the build vue polyfill command.

Review

…r click event handlers that jquery may not trigger.
@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 17, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 17, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@diosmosis diosmosis merged commit db89021 into 4.x-dev Feb 18, 2022
@diosmosis diosmosis deleted the vue-regression-expand-on-click branch February 18, 2022 03:44
@justinvelluppillai justinvelluppillai changed the title [Vue] Fix native click event handler not triggered on dashboard manager top control Fix native click event handler not triggered on dashboard manager top control Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants