Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to overwrite visit initial lat/long with each further ... #188

Closed
wants to merge 3 commits into from
Closed

added possibility to overwrite visit initial lat/long with each further ... #188

wants to merge 3 commits into from

Conversation

clearcode
Copy link

...action .

@mattab
Copy link
Member

mattab commented Jan 3, 2014

the logic in PR is already found in Tracker\Request overrideLocation($visitorInfo);

Calling this method will also bring country, region, city, lat, long overrides. Cheers

@clearcode
Copy link
Author

overrideLocation() only allows to pass lat/long in request in case when current request is first action of visit.
Any following action will not change visit's lat/long.
This PR purpose is to allow update lat/long in any following action of visit (for example for mobile users).

@mattab
Copy link
Member

mattab commented Jan 9, 2014

overrideLocation will override the following:

    static $locationOverrideParams = array(
        'country' => array('string', 'location_country'),
        'region'  => array('string', 'location_region'),
        'city'    => array('string', 'location_city'),
        'lat'     => array('float', 'location_latitude'),
        'long'    => array('float', 'location_longitude'),
    );

So it does also country / region / city. My feedback is to use this function rather than rewrite the code only for lat/long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants