@peterhashair opened this Pull Request on February 15th 2022 Contributor

Description:

Fixes: #18692

Cant not Copy User Dashboard for different sites with different access.

My guess was the getUser API endpoints, do have related param site Id, when site selector changes, getUser still return default site sitting maybe.

Question: do we allow users to copy the dashboard to themselves?

Review

@peterhashair commented on February 15th 2022 Contributor

Notes: This is a draft, not sure I am on the right track if that's not the case. I will look at it here
https://github.com/matomo-org/matomo/blob/8121427ba53127451bc74fdc3b0887e9843237e4/plugins/UsersManager/UserAccessFilter.php#L168-L182

@peterhashair commented on February 15th 2022 Contributor

@sgiehl that makes sense, will write tests for that, see if getUsers() covers different site ID permission.

@github-actions[bot] commented on March 23rd 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions[bot] commented on April 7th 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

This Pull Request was closed on April 8th 2022
Powered by GitHub Issue Mirror