Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmented visits log might show incorrect title #18792

Merged
merged 1 commit into from Feb 14, 2022
Merged

Segmented visits log might show incorrect title #18792

merged 1 commit into from Feb 14, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 14, 2022 •
edited

Description:

fixes #18775

I guess this might be a regression of the vue migration.

Steps to reproduce:

  • Go to any goal page
  • Click the link "Show Visits Log segmented by this Goal"
  • The title of the opened popover will contain some text of the rate feature

image

Review

@sgiehl sgiehl added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Feb 14, 2022
@sgiehl sgiehl added this to the 4.8.0 milestone Feb 14, 2022
@diosmosis
Copy link
Member

Looks good

@diosmosis diosmosis merged commit 40fbb28 into 4.x-dev Feb 14, 2022
@diosmosis diosmosis deleted the fixvlogtitle branch February 14, 2022 14:26
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Segmented visits log might show incorrect title
3 participants
@sgiehl @diosmosis @justinvelluppillai