Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate minTimestamp parameter for Live.getLastVisitsDetails #18791

Merged
merged 1 commit into from Feb 15, 2022
Merged

Validate minTimestamp parameter for Live.getLastVisitsDetails #18791

merged 1 commit into from Feb 15, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 14, 2022

Description:

fixes #18788

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 14, 2022
peterhashair
peterhashair approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sgiehl sgiehl added this to the 4.8.0 milestone Feb 15, 2022
@sgiehl sgiehl merged commit 8770ed0 into 4.x-dev Feb 15, 2022
@sgiehl sgiehl deleted the m18788 branch February 15, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Validate minTimestamp parameter for Live.getLastVisitsDetails
2 participants
@sgiehl @peterhashair