Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Allow specifying vue component as inline help. #18786

Merged
merged 2 commits into from Feb 14, 2022

Conversation

diosmosis
Copy link
Member

Description:

Angularjs approach to using html in inline help was to have a selector to a node that is moved, but this won't work with Vue, since the node may not be fully rendered by the time its moved. So now it's possible to specify a component as the inline-help. Will be used in tag manager first.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Feb 12, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 12, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@diosmosis diosmosis merged commit e56b1be into 4.x-dev Feb 14, 2022
@diosmosis diosmosis deleted the vue-inline-help-component branch February 14, 2022 14:15
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants