Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparing two segments in goals, sets the graph to all zeros for the first segment #18783

Closed
conflate-nl opened this issue Feb 12, 2022 · 3 comments · Fixed by #18844
Closed

Comparing two segments in goals, sets the graph to all zeros for the first segment #18783

conflate-nl opened this issue Feb 12, 2022 · 3 comments · Fixed by #18844
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.8.0

Comments

@conflate-nl
Copy link

When you go to the tab goals and select a specific goal, the graph and overview data show the amount of conversions for the current segment. Sometimes when you compare a secondary segment, the first segment shows all zeros on the y-axis in the graph. The overview below the graph still shows the correct numbers. (See screenshots).

I've tried this with several segments, and it looks like this is the case when the first segment contains multiple conditions. Furthermore, if the first segment contains just one condition, and the secondary segment contains multiple conditions, it does work.

Screenshot_20220212-102414_1
Screenshot_20220212-102247_1
@sgiehl
Copy link
Member

sgiehl commented Feb 23, 2022

@conflate-nl Thanks for creating this issue. It might have something to do with the segment definition. The evolution chart doesn't show the segment name in the series labels, but the definition. I'm wondering if the reason for that might maybe be the space in the segment definition. Does the behavior change if you switch the segments in the comparison?

@conflate-nl
Copy link
Author

conflate-nl commented Feb 24, 2022 •
edited

@sgiehl I did check this indeed

Furthermore, if the first segment contains just one condition, and the secondary segment contains multiple conditions, it does work.

So yes, switching the segments does work :-)

@sgiehl
Copy link
Member

sgiehl commented Feb 24, 2022

I tried digging deeper into that for a while. So the issue seems to be the space in the segment definition, but only if the segment is used as base segment to be compared with. The requests sent to load the widget don't contain the original segment like deviceType%3D%3Dfeature%252520phone, but deviceType%3D%3Dfeature%2520phone instead. So the space isn't triple, but only double encoded.

@diosmosis Could you have a look at that one? It seems to be a regression from the vue migrations, as it used to work e.g. in Matomo 4.6.0.

@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Feb 24, 2022
@sgiehl sgiehl added this to the 4.8.0 milestone Feb 24, 2022
@diosmosis diosmosis mentioned this issue Feb 24, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

[Vue] make sure segment is encoded properly in URL when AjaxHelper.fetch is used matomo-org/matomo
2 participants
@sgiehl @conflate-nl