Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] remove   in template #18777

Merged
merged 4 commits into from Feb 11, 2022
Merged

[Hotfix] remove   in template #18777

merged 4 commits into from Feb 11, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

remove nbsp

Review

@peterhashair peterhashair changed the title remove nbsp [Hotfix] remove nbsp in template Feb 11, 2022
@peterhashair peterhashair changed the title [Hotfix] remove nbsp in template [Hotfix] remove   in template Feb 11, 2022
@peterhashair peterhashair marked this pull request as ready for review February 11, 2022 03:56
@peterhashair peterhashair added the Needs Review PRs that need a code review label Feb 11, 2022
@diosmosis diosmosis merged commit 4371878 into 4.x-dev Feb 11, 2022
@diosmosis diosmosis deleted the hotfix-tests-fix branch February 11, 2022 10:39
@sgiehl
Copy link
Member

sgiehl commented Feb 11, 2022

Just out of curiosity, does that mean we shouldn't used   in Vue files at all? If so maybe we should document that somewhere

@diosmosis
Copy link
Member

@sgiehl Seems like it, unless its ok to remove/not apply the specific test in ReleaseCheckListTest. Unfortunately I have no idea why its there.

I have it on my list to document it in developer-documentation. It's still possible to use it, but you'd have to use a computed property.

@sgiehl
Copy link
Member

sgiehl commented Feb 11, 2022

Guess it would otherwise be fine to ignore the compiled Vue files in that check. Iirc the check was there to prevent accidentally inserted invisible/special characters

@diosmosis
Copy link
Member

I see, that's what I thought at first, but I guess I overthought.

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants