@diosmosis opened this Pull Request on February 10th 2022 Member

Description:

As title. I thought of skipping the UMD files, but I'm not sure why the test was originally added, and it looked related to security. Since   could be easily needed in the future it also doesn't seem acceptable to just never use it.

I found the place where this happens in the vue compiler and found a way to patch it.

Review

@peterhashair commented on February 10th 2022 Contributor

@diosmosis it still failed https://app.travis-ci.com/github/matomo-org/matomo/jobs/559193206. I guess just replace<p>&nbsp;</p> to <br/> maybe

@diosmosis commented on February 10th 2022 Member

@peterhashair that will fix it now, but it means using &nbsp; in vue templates is not allowed which seems like it could become a problem.

@diosmosis commented on February 10th 2022 Member

I can find one simple way to fix this but it the result still requires remembering and explaining something, so I don't think its much better than having to explain that   cannot be used directly in templates. Will close this.

This Pull Request was closed on February 10th 2022
Powered by GitHub Issue Mirror