[Vue] patch vue compiler so it does not decode entities #18770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
c: Tests & QA
11 tasks
|
@diosmosis it still failed https://app.travis-ci.com/github/matomo-org/matomo/jobs/559193206. I guess just replace |
|
@peterhashair that will fix it now, but it means using |
|
I can find one simple way to fix this but it the result still requires remembering and explaining something, so I don't think its much better than having to explain that cannot be used directly in templates. Will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As title. I thought of skipping the UMD files, but I'm not sure why the test was originally added, and it looked related to security. Since
could be easily needed in the future it also doesn't seem acceptable to just never use it.I found the place where this happens in the vue compiler and found a way to patch it.
Review