Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Add getBaseDatePickerOptions() method to global type defintion file. #18767

Merged
merged 1 commit into from Feb 13, 2022
Merged

[Vue] Add getBaseDatePickerOptions() method to global type defintion file. #18767

merged 1 commit into from Feb 13, 2022

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Feb 9, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 9, 2022
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 13, 2022
@peterhashair peterhashair merged commit 9e47cd0 into 4.x-dev Feb 13, 2022
@peterhashair peterhashair deleted the vue-add-get-base-date-picker-options branch February 13, 2022 21:58
peterhashair
peterhashair reviewed Feb 13, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @peterhashair