Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the selected conversion rate on Goals->Overview evolution graph #18766

Closed
weixuezhang opened this issue Feb 9, 2022 · 3 comments · Fixed by #19324
Closed

Show the selected conversion rate on Goals->Overview evolution graph #18766

weixuezhang opened this issue Feb 9, 2022 · 3 comments · Fixed by #19324
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@weixuezhang
Copy link

weixuezhang commented Feb 9, 2022

Goals->Overview, selecting any goal's conversion rate, on the top evolution graph always shows zero.

We can reproduce this issue on https://demo.matomo.cloud/.

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for Bugs)

Context

Your Environment

  • Matomo Version:
  • PHP Version:
  • Server Operating System:
  • Additionally installed plugins:
  • Browser:
  • Operating System:
@weixuezhang weixuezhang added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Feb 9, 2022
@bx80
Copy link
Contributor

bx80 commented Feb 9, 2022

Hi @weixuezhang, thanks for reporting this. It looks like the top evolution graph on the goals overview page doesn't load the goal conversion or conversion rate when clicking on a specific goal's details. Instead the overall period values are still shown (in my test these were not zero but still the wrong figures)

@bx80 bx80 changed the title Goals->Overview, selecting any goal's conversion rate, on the top evolution graph always shows zero. Goals->Overview evolution graph doesn't show the selected goal's conversion rate Feb 9, 2022
@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Feb 9, 2022
@justinvelluppillai justinvelluppillai added this to the 4.12.0 milestone Jun 7, 2022
@peterhashair peterhashair self-assigned this Jun 9, 2022
@peterhashair
Copy link
Contributor

when I was reviewing this issue, I realize, that after you refresh the page, the conversion rate showing correctly, but when you untick and tick the conversion box, it won't work. I guess a simple approach is to refresh the page after tick, but that won't be the perfect solution, still diving deep to see which JS cause the problem.

@sgiehl
Copy link
Member

sgiehl commented Jun 9, 2022

@peterhashair Did you try to analyze the requests that are sent to render the chart. I would assume that they differ when switching the metric and loading the chart already containing the metric. Knowing the difference should help to find the place where the request isn't build correctly.

@justinvelluppillai justinvelluppillai changed the title Goals->Overview evolution graph doesn't show the selected goal's conversion rate Show the selected conversion rate on Goals->Overview evolution graph Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants