Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect headline when adding a goal #18758

Merged
merged 1 commit into from Feb 8, 2022
Merged

Conversation

AltamashShaikh
Copy link
Contributor

Description:

The header for Add goal form get updated to "Update Goal" instead of "Add a new Goal" due to id set as string.

In Javascript

var test='0';
if(test){
console.log('if condition');
}else {
console.log('else condition');
}

The above code outputs "if condition" and due to which the title gets updated to "Update Goal"

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Feb 8, 2022
@sgiehl sgiehl changed the title Fixed goals header issue Fixes incorrect headline when adding a goal Feb 8, 2022
@sgiehl sgiehl added c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Needs Review PRs that need a code review labels Feb 8, 2022
@sgiehl sgiehl added this to the 4.8.0 milestone Feb 8, 2022
@sgiehl sgiehl merged commit ef4b336 into 4.x-dev Feb 8, 2022
@sgiehl sgiehl deleted the Fix-Goal-Header branch February 8, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants