Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Improve test for package build size #18751

Merged
merged 2 commits into from Feb 7, 2022
Merged

Fix/Improve test for package build size #18751

merged 2 commits into from Feb 7, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 7, 2022

Description:

replaces #18739

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 7, 2022
@sgiehl sgiehl added this to the 4.8.0 milestone Feb 7, 2022
@sgiehl sgiehl mentioned this pull request Feb 7, 2022
Closed
11 tasks
peterhashair
peterhashair approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@peterhashair peterhashair merged commit 6756236 into 4.x-dev Feb 7, 2022
@peterhashair peterhashair deleted the buildsize branch February 7, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @peterhashair