Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Correctly handle no group name in GroupedSettings. #18742

Merged
merged 2 commits into from Feb 5, 2022

Conversation

diosmosis
Copy link
Member

Description:

The prefix should not include "." in this case.

Review

@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Feb 4, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 4, 2022
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis was the migration of GroupedSettings already included in 4.7? Was wondering if that might cause any issues if so.

@diosmosis
Copy link
Member Author

@sgiehl it won't cause any issues, it's only used directly in vue code, and all the existing code supplies a groupName (so its never empty). Only noticed the issue w/ tag manager where it's not used.

@sgiehl sgiehl merged commit 66825fa into 4.x-dev Feb 5, 2022
@sgiehl sgiehl deleted the vue-grouped-settings-no-group branch February 5, 2022 09:09
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants