Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] fix component reference in Field, should be part of formField property #18741

Merged
merged 1 commit into from Feb 4, 2022

Conversation

diosmosis
Copy link
Member

Description:

component is meant to be part of the formField prop not passed in as its own. This shouldn't affect any existing code since all code I know of that uses component goes straight to FormField not to Field.

Review

@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 4, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Feb 4, 2022
@sgiehl sgiehl merged commit 48822b6 into 4.x-dev Feb 4, 2022
@sgiehl sgiehl deleted the vue-field-component-fix branch February 4, 2022 08:28
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants