Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Increase Release tests file lmited size from 55 to 56 #18739

Closed
wants to merge 8 commits into from

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Feb 4, 2022

Description:

Seems the Travis php@8.0 all tests-> release check tests. Start to fail, because file size increases. Update from 55 to 56.

Increase Release tests file limited size from 55 to 56

Review

@sgiehl
Copy link
Member

sgiehl commented Feb 4, 2022

@peterhashair I would guess that the test actually needs to be updated. It tries to exclude all files that are not included in the release. But the list of files is kind of outdated and the detection for dev only composer packages also seems incorrect.

This list needs to be checked:

$filesAndFoldersToDeleteFromPackage = [
# Should stay synchronised with: https://github.com/matomo/matomo-package/blob/master/scripts/build-package.sh#L104-L116
'composer.phar',

Also we are currently reading the composer.json file in order to check for dev only packages. But actually we should use composer.lock, as this file also includes several dependencies required by the dev packages we require.

@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Feb 4, 2022
@sgiehl
Copy link
Member

sgiehl commented Feb 7, 2022

closing in favor of #18751

@sgiehl sgiehl closed this Feb 7, 2022
@sgiehl sgiehl deleted the tests-increase-release-file-size branch February 7, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants