@peterhashair opened this Pull Request on February 4th 2022 Contributor

Description:

Seems the Travis php@8.0 all tests-> release check tests. Start to fail, because file size increases. Update from 55 to 56.

Increase Release tests file limited size from 55 to 56

Review

@sgiehl commented on February 4th 2022 Member

@peterhashair I would guess that the test actually needs to be updated. It tries to exclude all files that are not included in the release. But the list of files is kind of outdated and the detection for dev only composer packages also seems incorrect.

This list needs to be checked:
https://github.com/matomo-org/matomo/blob/f46abedba2ebf29b19d76f016e58b5ca686c4733/tests/PHPUnit/Integration/ReleaseCheckListTest.php#L816-L818

Also we are currently reading the composer.json file in order to check for dev only packages. But actually we should use composer.lock, as this file also includes several dependencies required by the dev packages we require.

@sgiehl commented on February 7th 2022 Member

closing in favor of #18751

This Pull Request was closed on February 7th 2022
Powered by GitHub Issue Mirror