Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed round fatal error in php8 #18732

Merged
merged 2 commits into from Feb 4, 2022
Merged

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Fixed round fatal error in php8.
Fixes: #DEV-2577

In PHP7.x
echo round('82,460.82'); // results in 82

Whereas for PHP 8
echo round('82,460.82'); // results in fatal error

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Feb 3, 2022
@AltamashShaikh AltamashShaikh marked this pull request as ready for review February 3, 2022 06:25
core/Columns/Dimension.php Outdated Show resolved Hide resolved
@sgiehl sgiehl added this to the 4.8.0 milestone Feb 4, 2022
@sgiehl sgiehl merged commit b132cac into 4.x-dev Feb 4, 2022
@sgiehl sgiehl deleted the DEV-2577-fix-round-fatal-error-php8 branch February 4, 2022 09:23
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants