[UI]update rocket icon to emoji #18729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 3, 2022 12:04
update rocket icon to emoji
add rocket icon image
This reverts commit 1241174.
update icon screenshot
peterhashair
added
Needs Review
|
If the font icon isn't in use anymore, I guess we can also remove it again |
added 2 commits
February 4, 2022 11:54
remove rocket icon font
This reverts commit 7a8e13c.
|
@sgiehl it seems like there are lots of places using Rocket Icon. Do we want to replace all of them with emojis? Otherwise, I think removing the icon will break some parts, some js Tests has click event on
|
|
@tsteur Shall we replace all usages of the rocket icon with the emoji, or only that specific one? |
|
not needed for now @sgiehl |
sgiehl
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18700
update rocket icon to emoji.
It seems like the emoji Character does not exist in the Travis, Exist in GitHub action. see here
Review