@peterhashair opened this Pull Request on February 2nd 2022 Contributor

Description:

Fixes: #18700
update rocket icon to emoji.
It seems like the emoji Character does not exist in the Travis, Exist in GitHub action. see here

Review

@sgiehl commented on February 3rd 2022 Member

If the font icon isn't in use anymore, I guess we can also remove it again

@peterhashair commented on February 3rd 2022 Contributor

@sgiehl it seems like there are lots of places using Rocket Icon. Do we want to replace all of them with emojis? Otherwise, I think removing the icon will break some parts, some js Tests has click event on .icon-rocket

image

@sgiehl commented on February 4th 2022 Member

@tsteur Shall we replace all usages of the rocket icon with the emoji, or only that specific one?

@tsteur commented on February 7th 2022 Member

not needed for now @sgiehl

This Pull Request was closed on February 7th 2022
Powered by GitHub Issue Mirror