New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] Expand event name table column change the table size. #18728
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
@peterhashair which part doesn't work there? |
@peterhashair your approach doesn't look right. The reason why the table gets smaller or displays a table fully cut of, is that we have a javascript that tries to determine the expected / required width of the table. It then sets a |
@sgiehl right that make sense, will update |
@peterhashair re the mobile issue: we don't want to create a table mobile view for now |
see https://matomo.org/docs/event-tracking/#implementing-event-tracking-with-matomo on how to track events. I believe this same issue applies though also to other reports, not just events. I believe the visitor generator might generate events too. |
update database table
8fe85a8
to
c57dfac
Compare
update table bug
shorter the query
update screenshot
Checked that on the events report. It seems when opening the first subtable the full table increases the width slightly. But opening further subtables don't change the width anymore and the automatically fit into the other tables width. |
make table size stable
@sgiehl should be stable size now. 😃 |
This reverts commit 1a72e1d.
@sgiehl just checking is that one good to merge :) |
@peterhashair So the current implementation still has the "issue" that the table might get a bit bigger when a subtable is opened, right? |
Not sure if it's caused by this or if it's a different issue. I had a case where the table now got a lot wider than the widget itself. but only in some cases when I opened eg the first row. When I opened the second row it was scrolling within the available area. I couldn't reproduce it on an older version but maybe it only happens in specific cases: Feb-15-2022.11-05-41.mp4This happens sometimes that eventually the width gets too wide and the content overflows. Apart from this I couldn't really reproduce the issue anymore I believe. |
update columns
@tsteur ah, right, I think this because the expanded has an extra column and the first column size changed. Did an update, it only recalculated once, I think should fix that problem. |
This reverts commit c11aec8.
@sgiehl find another solution, just resize once, should fits nows :) |
There is still the issue that smaller tables, like the report for events might slightly get wider when a subtable is opened. |
That be fine for me 👍 . Does the table only get a bit wider or is the content overflowing? Overflowing be a bigger issue. If that's the case, could we create an issue for this and fix it as part of Matomo 4.9? Either way be good to create a follow up issue that describes the problem and where it happens / when it happens. Then we can see if / when we fix it |
@peterhashair could you create a follow-up issue and merge this one afterwards. |
@sgiehl sure |
Description:
Fixes: #18699
Problem: When expanding the event name table column change the table size.
It seems like the line below,
$('tr:nth-child(1) td.label', domElem).length
is increase by 1 when expand. That makes the table label smaller. Should just first parent label length.matomo/plugins/CoreHome/javascripts/dataTable.js
Line 489 in f870e36
Review