@peterhashair opened this Pull Request on February 2nd 2022 Contributor

Description:

Fixes: #18699

Problem: When expanding the event name table column change the table size.

It seems like the line below,$('tr:nth-child(1) td.label', domElem).length is increase by 1 when expand. That makes the table label smaller. Should just first parent label length.
https://github.com/matomo-org/matomo/blob/f870e36a8993f91fcb5b5fd814c3fe6efbfd2690/plugins/CoreHome/javascripts/dataTable.js#L489

Review

@peterhashair commented on February 2nd 2022 Contributor

It seems on the mobile this part won't work as well, should I fix that issue as well @tsteur

image

@tsteur commented on February 3rd 2022 Member

@peterhashair which part doesn't work there?

@sgiehl commented on February 3rd 2022 Member

@peterhashair your approach doesn't look right. The reason why the table gets smaller or displays a table fully cut of, is that we have a javascript that tries to determine the expected / required width of the table. It then sets a max-width for the table. I guess if the calculation is fired too early the resulting values are incorrect. Maybe this is a regression of the migration of the widget loader to vue. But I guess we need to adjust the javascript

@peterhashair commented on February 3rd 2022 Contributor

@sgiehl right that make sense, will update

@tsteur commented on February 3rd 2022 Member

@peterhashair re the mobile issue: we don't want to create a table mobile view for now

@peterhashair commented on February 3rd 2022 Contributor

@sgiehl @tsteur sorry was trying the quick solution on demo.matomo.cloud browser CSS. Is there a way to generate some event name or can I copy the demo database to reproduce it locally

@tsteur commented on February 3rd 2022 Member

see https://matomo.org/docs/event-tracking/#implementing-event-tracking-with-matomo on how to track events. I believe this same issue applies though also to other reports, not just events.

I believe the visitor generator might generate events too.

@sgiehl commented on February 9th 2022 Member

Checked that on the events report. It seems when opening the first subtable the full table increases the width slightly. But opening further subtables don't change the width anymore and the automatically fit into the other tables width.
@peterhashair can you have a quick look if that can be fixed quickly. If it takes longer I would say this should be good enough as it is.

@peterhashair commented on February 9th 2022 Contributor

@sgiehl should be stable size now. 😃

@peterhashair commented on February 14th 2022 Contributor

@sgiehl just checking is that one good to merge :)

@sgiehl commented on February 14th 2022 Member

@peterhashair So the current implementation still has the "issue" that the table might get a bit bigger when a subtable is opened, right?
For me that solution would be fine for now, as it at least improves it a lot. @tsteur is that fine, or shall we again check if it's possible to fix the increasing size as well?

@tsteur commented on February 14th 2022 Member

Not sure if it's caused by this or if it's a different issue. I had a case where the table now got a lot wider than the widget itself. but only in some cases when I opened eg the first row. When I opened the second row it was scrolling within the available area. I couldn't reproduce it on an older version but maybe it only happens in specific cases:

https://user-images.githubusercontent.com/273120/153954648-4f04b64d-dca5-4800-aa44-909adbe15962.mp4

This happens sometimes that eventually the width gets too wide and the content overflows.

Apart from this I couldn't really reproduce the issue anymore I believe.

@peterhashair commented on February 14th 2022 Contributor

@tsteur ah, right, I think this because the expanded has an extra column and the first column size changed. Did an update, it only recalculated once, I think should fix that problem.

@peterhashair commented on February 18th 2022 Contributor

@sgiehl find another solution, just resize once, should fits nows :)

@sgiehl commented on February 21st 2022 Member

There is still the issue that smaller tables, like the report for events might slightly get wider when a subtable is opened.
I would suggest to leave that as is for now, at it seems not that easy to fix. The other issues seem fix.
@tsteur what do you think?

@tsteur commented on February 21st 2022 Member

That be fine for me 👍 . Does the table only get a bit wider or is the content overflowing? Overflowing be a bigger issue. If that's the case, could we create an issue for this and fix it as part of Matomo 4.9?

Either way be good to create a follow up issue that describes the problem and where it happens / when it happens. Then we can see if / when we fix it

@sgiehl commented on February 23rd 2022 Member

@peterhashair could you create a follow-up issue and merge this one afterwards.

@peterhashair commented on February 23rd 2022 Contributor

@sgiehl sure

This Pull Request was closed on February 23rd 2022
Powered by GitHub Issue Mirror