Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict plugin name to 60 characters #18727

Closed
tsteur opened this issue Feb 2, 2022 · 6 comments · Fixed by #19795
Closed

Restrict plugin name to 60 characters #18727

tsteur opened this issue Feb 2, 2022 · 6 comments · Fixed by #19795
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone
5.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Feb 2, 2022 •
edited

Follow up from https://github.com/matomo-org/matomo/pull/18723/files#r797936437

We have been using 40 characters in some columns, in some others 60 for plugin_name.

We should adjust isValidPluginName method to check the length in the regex and if not valid, throw an exception? It may be painful for some people to rename the plugin but at least on Marketplace the length has been already enforced.

The Marketplace itself enforces a length of 40 characters. Happy to increase this to 60 characters if better.

We want to make sure that

  • Marketplace and Matomo itself validate plugin name
  • All DB columns use same length
@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Feb 2, 2022
@tsteur tsteur added this to the 5.0.0 milestone Feb 2, 2022
@jane-twizel
Copy link

Let's increase this to 60 everywhere so it is consistent and this also means we won't have to address any names that are 40+

@peterhashair peterhashair mentioned this issue Sep 30, 2022
Merged
11 tasks
@peterhashair peterhashair self-assigned this Sep 30, 2022
@peterhashair peterhashair linked a pull request Sep 30, 2022 that will close this issue
Allow plugin names to be up to 60 characters instead of 40 #19795
Merged
11 tasks
@sgiehl
Copy link
Member

sgiehl commented Oct 4, 2022

Note: Once this has been changed, we also need to update the marketplace, as well as prepare a change for the documentation here: https://developer.matomo.org/guides/distributing-your-plugin#pluginjson-file

@peterhashair peterhashair mentioned this issue Oct 4, 2022
Closed
11 tasks
@mattab mattab added the 5.0.0 label Jan 4, 2023
@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2023

@tsteur could you adjust the marketplace to be able to handle plugins with a length of 60 chars? Seems I don't have access to the repo anymore.

@tsteur
Copy link
Member Author

tsteur commented Jan 31, 2023

@sgiehl I'll check this and also check the access as you should have access

@tsteur
Copy link
Member Author

tsteur commented Jan 31, 2023

@tsteur this is done. And you now also have access again

@sgiehl
Copy link
Member

sgiehl commented Feb 1, 2023

Awesome. Thanks. Then all parts of this issue should be solved 🎉

@sgiehl sgiehl closed this as completed Feb 1, 2023
@sgiehl sgiehl changed the title Restrict plugin name to 40 or 60 characters Restrict plugin name to 60 characters May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Allow plugin names to be up to 60 characters instead of 40 matomo-org/matomo
5 participants
@tsteur @mattab @sgiehl @peterhashair @jane-twizel