Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JQuery UI to 1.13.0 #18718

Merged
merged 2 commits into from Feb 8, 2022
Merged

Update JQuery UI to 1.13.0 #18718

merged 2 commits into from Feb 8, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 1, 2022

Description:

Review

@sgiehl sgiehl added this to the 4.8.0 milestone Feb 2, 2022
@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Feb 2, 2022
@sgiehl sgiehl marked this pull request as ready for review February 2, 2022 08:08
@cadeyrn
Copy link

cadeyrn commented Feb 3, 2022

FYI: jQuery UI 1.13.1 was released a few days ago.

@sgiehl
Copy link
Member Author

sgiehl commented Feb 3, 2022

@cadeyrn Thanks, I have seen that. We are currently using https://www.npmjs.com/package/jquery-ui-dist, and that wasn't updated yet.

@sgiehl sgiehl added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Feb 3, 2022
peterhashair
peterhashair approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sgiehl sgiehl merged commit cea5498 into 4.x-dev Feb 8, 2022
@sgiehl sgiehl deleted the jqueryuiupdate branch February 8, 2022 09:22
@justinvelluppillai justinvelluppillai changed the title Updates JQuery UI to 1.13.0 Update JQuery UI to 1.13.0 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @cadeyrn @peterhashair