Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes notification cancel ajaxHelper #18715

Merged
merged 5 commits into from Feb 2, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

Fixes: #18714
Fixes notification cancel ajaxHelper

Review

Peter Zhang added 2 commits January 31, 2022 17:01
* Update Sparkline.php

add addition setup

* Update Sparkline.php

update foreach to array_merge
@peterhashair peterhashair linked an issue Feb 1, 2022 that may be closed by this pull request
@sgiehl sgiehl requested a review from diosmosis February 1, 2022 08:16
@tsteur
Copy link
Member

tsteur commented Feb 1, 2022

@peterhashair is this ready for a review? Can you add the milestone and needs review label in that case?

@peterhashair peterhashair added the Needs Review PRs that need a code review label Feb 1, 2022
@peterhashair peterhashair added this to the 4.7.0 milestone Feb 1, 2022
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@peterhashair peterhashair merged commit 19cc16c into next_release Feb 2, 2022
@peterhashair peterhashair deleted the fixes-notifcation-cancel branch February 2, 2022 10:55
@sgiehl sgiehl modified the milestones: 4.7.0, 4.7.1 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed error when closing a notification
4 participants