Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error when closing a notification #18714

Closed
tsteur opened this issue Feb 1, 2022 · 1 comment · Fixed by #18715
Closed

Fixed error when closing a notification #18714

tsteur opened this issue Feb 1, 2022 · 1 comment · Fixed by #18715
Assignees
@peterhashair
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.7.1

Comments

@tsteur
Copy link
Member

tsteur commented Feb 1, 2022

Open Matomo,

Execute this code in browser console:

 var UI = require('piwik/UI');
var       notification =  new UI.Notification();
        notification.show('wwe', {context: 'error', id: 'test'});

Then close the notification. You will see such an error
image
image
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Feb 1, 2022
@tsteur tsteur added this to the 4.7.0 milestone Feb 1, 2022
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 1, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Feb 1, 2022 •
edited

It seems like the token param is not posted with the request.

@peterhashair peterhashair mentioned this issue Feb 1, 2022
Merged
11 tasks
@peterhashair peterhashair linked a pull request Feb 1, 2022 that will close this issue
Fixes notification cancel ajaxHelper #18715
Merged
11 tasks
@justinvelluppillai justinvelluppillai modified the milestones: 4.7.0, 4.8.0 Feb 2, 2022
@sgiehl sgiehl modified the milestones: 4.8.0, 4.7.1 Feb 3, 2022
@sgiehl sgiehl closed this as completed Feb 3, 2022
@justinvelluppillai justinvelluppillai changed the title Closing a notification causes an error Fixed error when closing a notification Feb 22, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.1
Development

Successfully merging a pull request may close this issue.

Fixes notification cancel ajaxHelper matomo-org/matomo
4 participants
@tsteur @justinvelluppillai @sgiehl @peterhashair