Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update orange brand color less variable in morpheus theme #18709

Closed
tsteur opened this issue Jan 31, 2022 · 1 comment · Fixed by #18717
Closed

Update orange brand color less variable in morpheus theme #18709

tsteur opened this issue Jan 31, 2022 · 1 comment · Fixed by #18717
Assignees
@sgiehl
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.8.0

Comments

@tsteur
Copy link
Member

tsteur commented Jan 31, 2022

If I see this right then @color-orange-brand: #ff9600; isn't used anywhere.

Yet at the same time we're using #f57c00 quite often for variables. In https://github.com/matomo-org/tag-manager/pull/416/files?short_path=2b826b2#diff-a3310714e534480dda01c12cc1fdd9062b60925c446ff3fad5e51b7bec4c9fa0R3 orange was used and I will be suggesting to use #f57c00.

Generally be great though to maybe define @color-orange-brand: #f57c00; so we can use @color-orange-brand maybe instead of #f57c00
@tsteur tsteur added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 31, 2022
@tsteur tsteur mentioned this issue Jan 31, 2022
Merged
11 tasks
@AltamashShaikh
Copy link
Contributor

Also it will be great if we can add the same in Morpheus

@sgiehl sgiehl self-assigned this Feb 1, 2022
@sgiehl sgiehl mentioned this issue Feb 1, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai added this to the 4.8.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Update color-orange-brand less variable matomo-org/matomo
4 participants
@tsteur @justinvelluppillai @sgiehl @AltamashShaikh