Prevent possible error when action is provided as array #18706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
sgiehl
commented
Jan 31, 2022
| @@ -460,6 +460,10 @@ protected function prepareDispatch($module, $action, $parameters) | |||
|
|
|||
| if (is_null($action)) { | |||
| $action = Common::getRequestVar('action', false); | |||
| if ($action !== false) { | |||
| // If a value was provided, check it has the correct type. | |||
| $action = Common::getRequestVar('action', null, 'string'); | |||
There was a problem hiding this comment.
This will throw an exception with the message The parameter 'action' doesn't have a correct type, and a default value wasn't provided.
Directly using Piwik::getAction() would in theory also work, but it would change the behavior slightly. Instead of throwing an error when an incorrect type was provided, it would use an empty string as default instead.
tsteur
reviewed
Jan 31, 2022
There was a problem hiding this comment.
LGTM. Some test is failing though: https://app.travis-ci.com/github/matomo-org/matomo/jobs/557678896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #18701
Review