Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Google SEO metrics are returned with correct type #18704

Merged
merged 1 commit into from Feb 8, 2022
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 31, 2022

Description:

fixes #18702

this is actually a regression from #18142

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 31, 2022
@sgiehl sgiehl added this to the 4.9.0 milestone Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Feb 8, 2022
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @sgiehl - any reason it's in the 4.9.0 milestone?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 8, 2022

@justinvelluppillai the original issue was assigned to 4.9.0. But should be fine to merge it for 4.8. already ;-)

@sgiehl sgiehl merged commit fd7b444 into 4.x-dev Feb 8, 2022
@sgiehl sgiehl deleted the m-18702 branch February 8, 2022 09:02
@sgiehl sgiehl modified the milestones: 4.9.0, 4.8.0 Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Google SEO metrics are returned with correct type
2 participants