Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy of set sparkline default color value, when key not exist. #18703

Merged
merged 2 commits into from Jan 31, 2022
Merged

copy of set sparkline default color value, when key not exist. #18703

merged 2 commits into from Jan 31, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jan 31, 2022 •
edited

Description:

cp of #18696
set sparkline default color value, when key not exist

Review

Peter Zhang added 2 commits January 31, 2022 17:01
set default color value, when key not exist. (#18696)
2de0357 
* Update Sparkline.php

add addition setup

* Update Sparkline.php

update foreach to array_merge
set default color value, when key not exist. (#18696)
2d21d63 
* Update Sparkline.php

add addition setup

* Update Sparkline.php

update foreach to array_merge
@peterhashair peterhashair marked this pull request as ready for review January 31, 2022 04:40
@peterhashair peterhashair merged commit 533a243 into next_release Jan 31, 2022
@peterhashair peterhashair deleted the cp-18534-fix branch January 31, 2022 04:41
@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2022

@peterhashair would be good to give even such PRs a describing name (before merging). The PRs name is used as commit message for the merge commit. And having a useful message might be good when looking through history

@sgiehl sgiehl added this to the 4.7.0 milestone Jan 31, 2022
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 31, 2022
@peterhashair peterhashair changed the title Cp 18534 fix copy of set default color value, when key not exist. Jan 31, 2022
@peterhashair peterhashair changed the title copy of set default color value, when key not exist. copy of set sparkline default color value, when key not exist. Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhashair @sgiehl