Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong rocket icon used in no data page #18700

Closed
tsteur opened this issue Jan 28, 2022 · 2 comments 路 Fixed by #18729
Closed

Wrong rocket icon used in no data page #18700

tsteur opened this issue Jan 28, 2022 · 2 comments 路 Fixed by #18729
Assignees
@peterhashair
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.8.0

Comments

@tsteur
Copy link
Member

tsteur commented Jan 28, 2022

Issue was created in #18458 to change the header and use the rocket icon
image

But the rocket icon looks like this:

image

Is it possible to use the actual rocket emoji 馃殌 maybe or is there an issue with this?
@tsteur tsteur added c: Design / UI For issues that impact Matomo's user interface or the design overall. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jan 28, 2022
@tsteur tsteur added this to the 4.8.0 milestone Jan 28, 2022
@sgiehl
Copy link
Member

sgiehl commented Jan 28, 2022

We are currently using an icon in the matomo font. Using an emoji should work as well, but it would be displayed differently on every operating system depending on the fonts. See e.g. https://emojipedia.org/rocket/

@tsteur
Copy link
Member Author

tsteur commented Jan 30, 2022

That be fine if it's displayed slightly differently 馃憤

@peterhashair peterhashair mentioned this issue Feb 2, 2022
Merged
11 tasks
@peterhashair peterhashair self-assigned this Feb 2, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

[UI]update rocket icon to emoji matomo-org/matomo
4 participants
@tsteur @justinvelluppillai @sgiehl @peterhashair