New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set default color value, when key not exist. #18696
Conversation
add addition setup
update foreach to array_merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge and doesn't look like any of the test failures are related to this change
was this merged to 4.x-dev on purpose, or should that fix have been in next_release? |
@sgiehl right, maybe should be in next_release. should I do a cherry pick on |
@peterhashair yes that be great, thanks |
* Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge
* Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge
* set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge * set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge
* set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge * Update Notification.vue quick fix * built vue files Co-authored-by: peterhashair <peterhashair@users.noreply.github.com>
* set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge * protected getPluginUmdChunks update private to protect
* tweak QueryParameters type in index.d.ts to better match arbitrary object types (#19191) * tweak QueryParameters type in index.d.ts to better match arbitrary object types * make sure github action takes into account changes in CoreVue types * add ability to use a deep watch in scope var watches in angularjs adapters (#19195) * covert getPluginUmdChunks from private to protected (#19212) * set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge * protected getPluginUmdChunks update private to protect * correctly destroy vue entry components in widgetloader (#19216) * Release Matomo 4.10.0 Co-authored-by: dizzy <diosmosis@users.noreply.github.com> Co-authored-by: Peter Zhang <peter@innocraft.com>
Description:
Fixes: #18534
set default color value, when key not exist.
Review