Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem where dashboards can't be copied to users in certain circumstances #18692

Closed
Starker3 opened this issue Jan 27, 2022 · 10 comments · Fixed by #19199
Closed

Fixes problem where dashboards can't be copied to users in certain circumstances #18692

Starker3 opened this issue Jan 27, 2022 · 10 comments · Fixed by #19199
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@Starker3
Copy link
Contributor

Refs DEV-2411
Not sure exactly under what circumstances this bug occurs, but in some cases its not possible to copy a dashboard to a different user.

For example we had a case where an Admin user was not able to copy a dashboard to a specific View user. They were able to copy to some View users and other Admin users, but several View users were not showing on the list when trying to copy.
Other Admin users were also not able to copy to that specific View users until that View user was made an Admin user.

Thomas mentioned that this might be something that only happens under certain circumstances depending on what users exist:
image

@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jan 27, 2022
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jan 27, 2022
@tsteur tsteur added this to the 4.8.0 milestone Jan 27, 2022
@peterhashair peterhashair self-assigned this Feb 3, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Feb 3, 2022

Just trying to reproduce this one, the only case I found. When your site Selector is Site 2. And Permission as listed below, this will appear. @Starker3 @tsteur is that sound about the right reproduction?

Site 1:

  • Admin:
    User A
  • No Access:
    User B

Site 2

  • Admin:
    User B
  • View:
    User A

@Starker3
Copy link
Contributor Author

Starker3 commented Feb 9, 2022

@peterhashair That might be how to reproduce it, if you want I can test it and see if I get the same results with such a setup?

@peterhashair
Copy link
Contributor

@Starker3 that would be great.

@justinvelluppillai
Copy link
Contributor

Hey @Starker3 did you get a chance to have a look here?

@justinvelluppillai
Copy link
Contributor

Also @peterhashair is this fixed in #18796 ?

@justinvelluppillai justinvelluppillai modified the milestones: 4.9.0, 4.10.0 Apr 12, 2022
@Starker3
Copy link
Contributor Author

@justinvelluppillai @peterhashair The setup that Peter gave for reproduction doesn't work for me to reproduce this.
I had the users configured as follows:
Site 1:
Admin: User A
No Access: User B

Site 2
Admin: User B
View: User A

For Site 2 both User A and User B were able to see each other in the list when copying dashboards. The Super Users were not visible in that list, but I'm not sure if that is intentional or not?

@sgiehl
Copy link
Member

sgiehl commented Apr 29, 2022

@Starker3 Do you remember if the users that weren't shown might have had write access?
Looking at the code it seems we check if a user has admin or view access. But users with write access might be ignored.

@sgiehl
Copy link
Member

sgiehl commented May 24, 2022

@Starker3 Are you sure the user had view access? I was able to reproduce it with a user having write permission, which then wasn't visible for an admin. The PR would fix this.

@Starker3
Copy link
Contributor Author

@sgiehl I don't remember the specifics for the permissions level of the users when I encountered this error.
I can test it again though and see if I can reproduce it. I'll get back to you once I've tried that.

@sgiehl
Copy link
Member

sgiehl commented May 25, 2022

@Starker3 if you are able to reproduce that with vier permission, please reopen the issue. For write permission this should be fixed with 4.11. then.

@justinvelluppillai justinvelluppillai changed the title Cannot copy dashboard to users in certain circumstances Fixes problem where dashboards can't be copied to users in certain circumstances Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
5 participants