@peterhashair opened this Pull Request on January 26th 2022 Contributor

Description:

Fixes: #18138
Cache whether a DB supports transaction on all the DB adapter to improve perfomance.

Review

@peterhashair commented on February 2nd 2022 Contributor

@tsteur right, so this $supportsUncommitted should be in the Db.php.

@sgiehl commented on February 4th 2022 Member

@peterhashair most tests are now failing with messages like Undefined property: Piwik\Db\Adapter\Pdo\Mysql::$supportsUncommitted. Maybe it needs to be added to the adapters as well...

@peterhashair commented on February 10th 2022 Contributor

@sgiehl I think that one is good to go?

@sgiehl commented on February 10th 2022 Member

From my point of view this looks good to merge.

@peterhashair commented on February 16th 2022 Contributor

@sgiehl right, sorry wasn't thinking, update again, if that makes sense.

This Pull Request was closed on February 23rd 2022
Powered by GitHub Issue Mirror