Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add random number fields in tests to skip some random number failed #18688

Closed

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jan 26, 2022

Description:

add random number fields in tests to skip some random number failed
eg:

- <nb_visits>1</nb_visits>
+ <nb_visits>2</nb_visits>

will be <nb_visits>x</nb_visits>

Review

Peter added 2 commits January 26, 2022 14:18
add random number fields
add random number fields
@sgiehl
Copy link
Member

sgiehl commented Jan 26, 2022

@peterhashair Are you able to explain why those random results are actually occurring? It's not the best choice to simply ignore them unless we can be fully safe that they are kind of expected.

@peterhashair
Copy link
Contributor Author

peterhashair commented Jan 26, 2022

@sgiehl ah, haven't found why this is happing, will look deeper, but the one I am after is those 2.

image

image

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Feb 10, 2022
@sgiehl sgiehl deleted the fIx-blobReportLimitingTest-random-failed branch April 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants