@peterhashair opened this Pull Request on January 26th 2022 Contributor

Description:

Fixes: #18639
Accidently click merge on original PR https://github.com/matomo-org/matomo/pull/18653, revert it.

Review

@sgiehl commented on February 1st 2022 Member

Overall the code looks fine, but the errors described in the original issue are actually still showing up as warnings in the log:

WARNING MultiSites[2022-02-01 14:30:24 UTC] [09f2b] /srv/matomo/core/Date.php(1079): Deprecated - strtolower(): Passing null to parameter <a href='/1'>#1</a> ($string) of type string is deprecated - Matomo 4.7.0-rc1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already) [internal function]: Piwik\ErrorHandler::errorHandler(),<a href='/1'>#1</a>/core/Date.php(1079),<a href='/2'>#2</a>/core/Period/Range.php(255),<a href='/3'>#3</a>/core/Period.php(131),<a href='/4'>#4</a>/core/Period/Range.php(152),<a href='/5'>#5</a>/core/Period/Range.php(543),<a href='/6'>#6</a>/core/Plugin/Controller.php(491),<a href='/7'>#7</a>/plugins/MultiSites/Controller.php(97),<a href='/8'>#8</a>/plugins/MultiSites/Controller.php(37),[internal function]: Piwik\Plugins\MultiSites\Controller->index()

I guess to solve that you may need to change this:
https://github.com/matomo-org/matomo/blob/83ed55c06e96a9423f0d1101cec05c233ec403a3/plugins/MultiSites/Controller.php#L97
and supply ['period' => $period] as parameter for the method call.

This Pull Request was closed on February 14th 2022
Powered by GitHub Issue Mirror