@peterhashair opened this Pull Request on January 24th 2022 Contributor

Description:

copy of 18672(https://github.com/matomo-org/matomo/pull/18672)

Review

@tsteur commented on January 24th 2022 Member

btw requires this a new vue build?

note: this refs https://github.com/matomo-org/matomo/pull/18672

@peterhashair commented on January 25th 2022 Contributor

@tsteur I think it does need a new VUE to build, it's part of the CoreHome ts file, the original had a random VUE build that failed stopped halfway.

@sgiehl commented on January 25th 2022 Member

@peterhashair be good to check if vue builds ran correctly before approving a PR. I'm actually wondering how you did some sort of testing in the UI for the other PR without building the vue files.

@peterhashair commented on January 25th 2022 Contributor

@sgiehl probably the complied js is already exist in the branch.

@sgiehl commented on January 25th 2022 Member

In this PR yes. But not in the one that was already merged to 4.x-dev

@sgiehl commented on January 25th 2022 Member

Sure. But without the update you won't see the changes in the ui

@sgiehl commented on January 25th 2022 Member

But actually that doesn't matter that much. If a PR changes something in a Vue or typescript file, it's in almost all cases needed that the built Vue files are updated. And if that isn't the case we shouldn't approve the PR or rerun the action before approving it to ensure the PR only will be merged with built files.

@peterhashair commented on January 25th 2022 Contributor

@sgiehl sorry about that, just realise merge won't build vue it again.

This Pull Request was closed on January 26th 2022
Powered by GitHub Issue Mirror