@peterhashair
Description:
copy of 18672(https://github.com/matomo-org/matomo/pull/18672)
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@tsteur
btw requires this a new vue build?
note: this refs https://github.com/matomo-org/matomo/pull/18672
@tsteur I think it does need a new VUE to build, it's part of the CoreHome ts file, the original had a random VUE build that failed stopped halfway.
@sgiehl
@peterhashair be good to check if vue builds ran correctly before approving a PR. I'm actually wondering how you did some sort of testing in the UI for the other PR without building the vue files.
@sgiehl probably the complied js is already exist in the branch.
In this PR yes. But not in the one that was already merged to 4.x-dev
Sure. But without the update you won't see the changes in the ui
But actually that doesn't matter that much. If a PR changes something in a Vue or typescript file, it's in almost all cases needed that the built Vue files are updated. And if that isn't the case we shouldn't approve the PR or rerun the action before approving it to ensure the PR only will be merged with built files.
@sgiehl sorry about that, just realise merge won't build vue it again.