New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy of the other PR #18680
copy of the other PR #18680
Conversation
btw requires this a new vue build? note: this refs #18672 |
@tsteur I think it does need a new VUE to build, it's part of the |
@peterhashair be good to check if vue builds ran correctly before approving a PR. I'm actually wondering how you did some sort of testing in the UI for the other PR without building the vue files. |
@sgiehl probably the complied js is already exist in the branch. |
In this PR yes. But not in the one that was already merged to 4.x-dev |
Sure. But without the update you won't see the changes in the ui |
But actually that doesn't matter that much. If a PR changes something in a Vue or typescript file, it's in almost all cases needed that the built Vue files are updated. And if that isn't the case we shouldn't approve the PR or rerun the action before approving it to ensure the PR only will be merged with built files. |
@sgiehl sorry about that, just realise merge won't build vue it again. |
Description:
copy of 18672(#18672)
Review