Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy of the other PR #18680

Merged
merged 2 commits into from Jan 26, 2022
Merged

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jan 24, 2022

Description:

copy of 18672(#18672)

Review

@tsteur
Copy link
Member

tsteur commented Jan 24, 2022

btw requires this a new vue build?

note: this refs #18672

@peterhashair
Copy link
Contributor Author

@tsteur I think it does need a new VUE to build, it's part of the CoreHome ts file, the original had a random VUE build that failed stopped halfway.

@tsteur tsteur added this to the 4.7.0 milestone Jan 25, 2022
@tsteur tsteur added the Needs Review PRs that need a code review label Jan 25, 2022
@sgiehl
Copy link
Member

sgiehl commented Jan 25, 2022

@peterhashair be good to check if vue builds ran correctly before approving a PR. I'm actually wondering how you did some sort of testing in the UI for the other PR without building the vue files.

@peterhashair
Copy link
Contributor Author

@sgiehl probably the complied js is already exist in the branch.

@sgiehl
Copy link
Member

sgiehl commented Jan 25, 2022

In this PR yes. But not in the one that was already merged to 4.x-dev

@sgiehl
Copy link
Member

sgiehl commented Jan 25, 2022

Sure. But without the update you won't see the changes in the ui

@sgiehl
Copy link
Member

sgiehl commented Jan 25, 2022

But actually that doesn't matter that much. If a PR changes something in a Vue or typescript file, it's in almost all cases needed that the built Vue files are updated. And if that isn't the case we shouldn't approve the PR or rerun the action before approving it to ensure the PR only will be merged with built files.

@peterhashair
Copy link
Contributor Author

peterhashair commented Jan 25, 2022

@sgiehl sorry about that, just realise merge won't build vue it again.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jan 26, 2022
@sgiehl sgiehl merged commit 972bbb2 into next_release Jan 26, 2022
@sgiehl sgiehl deleted the cp-vue-ignore-initial-property-watch branch January 26, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants