@peterhashair opened this Pull Request on January 23rd 2022 Contributor

Description:

Fork https://github.com/matomo-org/matomo/pull/18290
update github-action branch has some unnecessary UI updates Test 4.x branch, not sure why but seems like php8.0 MySQLi driver has a poor performance here

UI viewer test:
Because the silex is out of sup. Here is the Symfony version of it, but at the moment only tested github action part not fully test travis. https://github.com/matomo-org/ui-tests-viewer/tree/php-8-symfony

Review

@peterhashair commented on February 8th 2022 Contributor

@sgiehl revert some unnecessary code form change. that should make review easier.

@peterhashair commented on February 10th 2022 Contributor

advantage:

  • The last commit will be canceled the preview build.
  • It seems like Github action overall will be 2-10 mins quicker.

disadvantage:

  • Entire Pipeline is running as a whole, you can not rerun a single job.
  • It seems php8.0 + MySQLI driver is very slow. not sure why could be sth to do with MariaDB.
  • Github Action is free on the public repo, but the limit is 20 concurrency jobs per repo. Meaning the max pipeline at the same time are 3 PR requests. Fork will remove the limit if we want to go this path.
  • The main test should wait for VUE/PHPCS build finished, then continue. But that option only works on the default branch, which is 4.x-dev. Or we could merge VUE, PHPCS build and test to one pipeline as a step

Push Live Require. Just a list for this to progress.

  • [ ] [Review] Code review on this branch.

  • [ ] [Decision] do we need Travis and Github action running at the same time, or completely remove Travis
    Suggestion: We keep both running for at least 1 week.

  • [ ] [Review] Submodule PR review. Submodule target change to 4. x-dev

  • [ ] [Decision] do we allow UI upload for public fork repo. Do we consider displaying the failed UI HTML inside GitHub action?

  • [ ] Doc] Documentation for development guild

  • [ ] [Doc] Documentation for internal staff use.

@github-actions[bot] commented on February 21st 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@peterhashair commented on March 6th 2022 Contributor

@tsteur somehow this test on MySQL running really slow, but MariaDB is a little bit quick. Any idea? PHP (SystemTestsCore, 8.0, MYSQLI)

@tsteur commented on March 7th 2022 Member

@peterhashair no idea why but you could either try setting testdox=true in the phpunit.xml.dist and then monitor if it's one particular test that takes a while. Or I believe there is also another feature maybe to print how long each test took to execute in phpunit. This would then help you figure out if there's one or few tests that are slow or all of them.

I just checked and testdox gave me this output for example:

image
@github-actions[bot] commented on March 17th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on March 24th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on April 1st 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on April 9th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions[bot] commented on April 20th 2022 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@peterhashair commented on May 6th 2022 Contributor

@sgiehl move all tests to here https://github.com/matomo-org/github-action-tests makes more sense, but needs a little work, start working on it.

@github-actions[bot] commented on June 10th 2022 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

Powered by GitHub Issue Mirror