New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github Action] Test 4.x branch #18679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhashair
added
the
c: Tests & QA
For issues related to automated tests or making it easier to QA & test issues.
label
Feb 1, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Feb 21, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Mar 17, 2022
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Mar 24, 2022
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Apr 1, 2022
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Apr 9, 2022
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Apr 20, 2022
sgiehl
removed
Needs Review
PRs that need a code review
Stale
The label used by the Close Stale Issues action
labels
May 5, 2022
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Stale
The label used by the Close Stale Issues action
label
Jun 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
11 tasks
…, as it's bundled with core
sgiehl
force-pushed
the
github-action-v2
branch
2 times, most recently
from
January 31, 2023 09:30
bf7b293
to
364eff1
Compare
sgiehl
force-pushed
the
github-action-v2
branch
from
January 31, 2023 09:37
364eff1
to
3227431
Compare
sgiehl
force-pushed
the
github-action-v2
branch
from
January 31, 2023 12:32
989418a
to
39f995c
Compare
Build finally succeeded. Even though there are still some randomly failing tests like before. |
sgiehl
added
the
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
label
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: Tests & QA
For issues related to automated tests or making it easier to QA & test issues.
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fork #18290
update github-action branch has some unnecessary UI updates Test 4.x branch, not sure why but seems like php8.0 MySQLi driver has a poor performance here
UI viewer test:
Because the silex is out of sup. Here is the Symfony version of it, but at the moment only tested the GitHub action part not fully tested Travis. https://github.com/matomo-org/ui-tests-viewer/pull/40
YML, PDF:
when tests failed, the system will upload the artifact as zip and stay on Github for 5 days
Once this is merged to 4.x-dev, we can use the below to wait for the other process finished. Only works on default branch
Performance
It seems like the
MYSQLI
is twice slower as thePDO
driver, not sure why.Review