Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply disableAlwaysUseSendBeacon first #18676

Merged
merged 1 commit into from Jan 31, 2022
Merged

Apply disableAlwaysUseSendBeacon first #18676

merged 1 commit into from Jan 31, 2022

Conversation

Sir-Will
Copy link
Contributor

Description:

disableAlwaysUseSendBeacon should be applied first like alwaysUseSendBeacon, otherwise it only works when being pushed as first entry to _paq.

Review

@tsteur tsteur added this to the 4.8.0 milestone Jan 24, 2022
@tsteur tsteur added the Needs Review PRs that need a code review label Jan 24, 2022
@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2022

Hi @Sir-Will. Thanks for your pull request. Changes to js/piwik.js also require our minified javascript files to be rebuilt. You can find more about building those files here: https://github.com/matomo-org/matomo/blob/4.x-dev/js/README.md#deployment

I will merge your PR into another branch for now, and built the js files myself. For future PRs it would be awesome if you could do that as well if possible.

@sgiehl sgiehl changed the base branch from 4.x-dev to temp January 31, 2022 14:22
@sgiehl sgiehl merged commit ae97560 into matomo-org:temp Jan 31, 2022
@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Needs Review PRs that need a code review labels Jan 31, 2022
@sgiehl sgiehl mentioned this pull request Jan 31, 2022
Merged
11 tasks
sgiehl added a commit that referenced this pull request Jan 31, 2022
@sgiehl @Sir-Will
Apply disableAlwaysUseSendBeacon first (#18708)
ee657c0 
* Apply `disableAlwaysUseSendBeacon` first (#18676)

* built tracker js files

Co-authored-by: Sir-Will <brieftaubenman@gmail.com>
@Sir-Will
Copy link
Contributor Author

Sir-Will commented Feb 1, 2022

Noted 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sir-Will @sgiehl @tsteur