Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove @types plugin dir before building to clear old types #18673

Merged
merged 2 commits into from Jan 24, 2022
Merged

[Vue] remove @types plugin dir before building to clear old types #18673

merged 2 commits into from Jan 24, 2022

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 22, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Jan 22, 2022
peterhashair
peterhashair reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is always an angular test that failed, but Travis didn't pick up.
image

@diosmosis
Copy link
Member Author

@peterhashair should hopefully be fixed w/ the latest push.

@peterhashair peterhashair merged commit fed704e into 4.x-dev Jan 24, 2022
@peterhashair peterhashair deleted the vue-delete-types-on-build branch January 24, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @peterhashair