Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] do not angularjs watcher in createAngularJsAdapter on first watch execution #18672

Merged
merged 1 commit into from Jan 24, 2022
Merged

[Vue] do not angularjs watcher in createAngularJsAdapter on first watch execution #18672

merged 1 commit into from Jan 24, 2022

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 22, 2022
@diosmosis diosmosis added this to the 4.8.0 milestone Jan 22, 2022
@diosmosis diosmosis mentioned this pull request Jan 22, 2022
Closed
11 tasks
peterhashair
peterhashair approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like vue build failed, but looks unrelated

@diosmosis diosmosis merged commit fc4109e into 4.x-dev Jan 24, 2022
@diosmosis diosmosis deleted the vue-ignore-initial-property-watch branch January 24, 2022 11:16
@tsteur
Copy link
Member

tsteur commented Jan 24, 2022

@sgiehl @peterhashair I believe this should go into next_release Otherwise the regression won't be fixed?

@peterhashair
Copy link
Contributor

@tsteur ah, this is already merged to 4.x-dev. should I do a new PR copy of this to next_release ?

@tsteur
Copy link
Member

tsteur commented Jan 24, 2022

be good. You'll probably want to do a cherry-pick for this merge so there won't be any merge conflicts later . Like create a new branch off next_release and then maybe do something like git cherry-pick fc4109e79a79e29a75f0cee582eab1d23cbb9eb3

peterhashair pushed a commit that referenced this pull request Jan 24, 2022
@diosmosis
do not angularjs watcher in createAngularJsAdapter on first watch exe…
a684e96 
…cution (#18672)
@tsteur tsteur mentioned this pull request Jan 24, 2022
Merged
11 tasks
sgiehl pushed a commit that referenced this pull request Jan 26, 2022
@diosmosis @peterhashair
copy of the other PR (#18680)
972bbb2 
* do not angularjs watcher in createAngularJsAdapter on first watch execution (#18672)

* built vue files

Co-authored-by: dizzy <diosmosis@users.noreply.github.com>
Co-authored-by: peterhashair <peterhashair@users.noreply.github.com>
@diosmosis diosmosis mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @tsteur @peterhashair