Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Fixes #18663, make sure $location is initialized early. #18671

Merged
merged 1 commit into from Jan 24, 2022
Merged

[Vue] Fixes #18663, make sure $location is initialized early. #18671

merged 1 commit into from Jan 24, 2022

Conversation

diosmosis
Copy link
Member

Description:

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 21, 2022
@diosmosis diosmosis added this to the 4.7.0 milestone Jan 21, 2022
@diosmosis diosmosis mentioned this pull request Jan 21, 2022
Closed
peterhashair
peterhashair approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@diosmosis diosmosis merged commit aaf7b27 into 4.x-dev Jan 24, 2022
@diosmosis diosmosis deleted the vue-location-init branch January 24, 2022 11:17
@sgiehl
Copy link
Member

sgiehl commented Jan 25, 2022

I guess this one should have gone to next_release as well, as it fixes a regression in 4.7

@tsteur
Copy link
Member

tsteur commented Jan 25, 2022

@peterhashair could you recreate this PR for next_release branch as well?

@peterhashair
Copy link
Contributor

@tsteur sure

peterhashair pushed a commit that referenced this pull request Jan 25, 2022
@diosmosis
Fixes #18663, make sure $location is initialized early. (#18671)
0e2e563
@peterhashair peterhashair mentioned this pull request Jan 25, 2022
Merged
11 tasks
sgiehl pushed a commit that referenced this pull request Jan 26, 2022
@diosmosis
Fixes #18663, make sure $location is initialized early. (#18671) (#18683
1b73c39 
)

Co-authored-by: dizzy <diosmosis@users.noreply.github.com>
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jan 26, 2022
@sgiehl sgiehl modified the milestones: 4.7.0, 4.8.0 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @sgiehl @tsteur @peterhashair