Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] fix eager update on array text fields, do not update if values are basically the same #18670

Merged
merged 1 commit into from Jan 21, 2022
Merged

[Vue] fix eager update on array text fields, do not update if values are basically the same #18670

merged 1 commit into from Jan 21, 2022

Conversation

diosmosis
Copy link
Member

… so spaces can be deleted

Description:

Can be reproduced on sites global settings edit page by trying to delete a space character from the "Tracking Internal Site Search > query parameter" search text field.

Review

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jan 21, 2022
@diosmosis diosmosis added this to the 4.7.0 milestone Jan 21, 2022
sgiehl
sgiehl approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@sgiehl sgiehl merged commit d499cdc into next_release Jan 21, 2022
@sgiehl sgiehl deleted the vue-fix-field-array-eager-update branch January 21, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl