Run scheduled report tests on any PHP version #18666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We have a couple of scheduled report tests that are only executed on certain systems:
matomo/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
Lines 251 to 273 in 9fa38fe
matomo/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
Lines 315 to 396 in 9fa38fe
If I remember correctly we had some issues when running those tests on PHP 5 and PHP 7, as the results differed back then.
It seems that isn't a problem anymore when running them on PHP 7 and PHP 8. At least there are no tests failing.
But based on the number of test cases it looks like they are executed.
refs #18499