Fix possible error when generating PDF reports containing multibyte chars #18664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When generating the tables for PDF reports we are truncating the row values after a certain amount of chars (55). If a string contained a multibyte character (umlauts, emojis, ...) around this position, it happened, that the multibyte sequence was disrupted.
This did cause any bigger issues on PHP 7, where only parts of the string were displayed in the PDF
On PHP 8 this produced an error, causing an abort of the PDF generation.
Simply using
mb_substr
instead ofsubstr
fixes this issue for me.If someone wants to reproduce:
öööööööööööööööööööööööööööööööööööööööööööööööööööööööööööö
@tsteur I've targeted
next_release
as it's really a minimal, low-risk changefixes #18499
Review