Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add date, period params into common function #18653

Merged
merged 9 commits into from Jan 26, 2022
Merged

add date, period params into common function #18653

merged 9 commits into from Jan 26, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jan 19, 2022 •
edited

Description:

Fixes: #18639

Extend common:getRequestVar, if type = null, but array passed, convert to string.

Review

Update Common.php
01efbc9 
add array check in common request
@peterhashair peterhashair added this to the 4.8.0 milestone Jan 19, 2022
sgiehl
sgiehl reviewed Jan 19, 2022
View reviewed changes
core/Common.php Outdated Show resolved Hide resolved
sgiehl
sgiehl requested changes Jan 20, 2022
View reviewed changes
core/Piwik.php Outdated Show resolved Hide resolved
core/Piwik.php Outdated Show resolved Hide resolved
core/Piwik.php Outdated Show resolved Hide resolved
core/Piwik.php Outdated Show resolved Hide resolved
Peter Zhang and others added 3 commits January 21, 2022 09:25
@sgiehl
Update core/Piwik.php
eaa8665 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl
Update core/Piwik.php
5b633a7 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
update function
83ed55c 
update function
@peterhashair peterhashair added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jan 20, 2022
sgiehl
sgiehl reviewed Jan 21, 2022
View reviewed changes
core/Piwik.php Outdated Show resolved Hide resolved
core/Plugin/Controller.php Show resolved Hide resolved
@sgiehl
Update core/Piwik.php
171e921 
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@peterhashair peterhashair changed the title add array or string in common request add date, period params into common function Jan 23, 2022
Update Controller.php
44f3c09 
update isset check
@peterhashair peterhashair marked this pull request as ready for review January 26, 2022 00:13
@peterhashair peterhashair merged commit a0705d8 into 4.x-dev Jan 26, 2022
@peterhashair peterhashair deleted the m-18639-array-request-params branch January 26, 2022 00:14
@peterhashair peterhashair restored the m-18639-array-request-params branch January 26, 2022 00:15
peterhashair added a commit that referenced this pull request Jan 26, 2022
@peterhashair
Revert "add date, period params into common function (#18653)"
6996d30 
This reverts commit a0705d8.
peterhashair pushed a commit that referenced this pull request Jan 26, 2022
Revert "add date, period params into common function (#18653)" (#18685)
da4be81 
This reverts commit a0705d8.
@peterhashair peterhashair deleted the m-18639-array-request-params branch January 26, 2022 00:18
@peterhashair peterhashair restored the m-18639-array-request-params branch January 26, 2022 00:19
This was referenced Jan 26, 2022
Merged
Merged
@sgiehl sgiehl deleted the m-18639-array-request-params branch April 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

strtolower(): Argument #1 ($string) must be of type string, array given in Date.php
2 participants
@peterhashair @sgiehl